Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCI provider: bump oci-go-sdk from 24.3.0 to 65.35.0 #3556

Merged
merged 1 commit into from
Apr 20, 2023
Merged

OCI provider: bump oci-go-sdk from 24.3.0 to 65.35.0 #3556

merged 1 commit into from
Apr 20, 2023

Conversation

jrosinsk
Copy link
Contributor

@jrosinsk jrosinsk commented Apr 19, 2023 •
edited
Loading

Description

Bumps github.com/oracle/oci-go-sdk from 24.3.0 to 65.35.0.

Testing
Deployed the sample service from the OCI Tutorial doc
redacted results below

INFO[0000] Instantiating new Kubernetes client
INFO[0000] Using kubeConfig
INFO[0000] Created Kubernetes client https://X.X.X.X:XX
INFO[0010] All records are already up to date
INFO[0066] All records are already up to date
INFO[0133] Change zone: "ocid1.dns-zone.oc1..162fffffffffffffffffffffffee1cabf"
INFO[0133] { Domain=nginx.jrosinsk.developer.redacted.com RecordHash=<nil> IsProtected=<nil> Rdata=x.x.x.x RrsetVersion=<nil> Rtype=A Ttl=300 Operation=ADD }
INFO[0133] { Domain=nginx.jrosinsk.developer.redacted.com RecordHash=<nil> IsProtected=<nil> Rdata="heritage=external-dns,external-dns/owner=default,external-dns/resource=service/default/nginx" RrsetVersion=<nil> Rtype=TXT Ttl=300 Operation=ADD }
INFO[0133] { Domain=a-nginx.jrosinsk.developer.redacted.com RecordHash=<nil> IsProtected=<nil> Rdata="heritage=external-dns,external-dns/owner=default,external-dns/resource=service/default/nginx" RrsetVersion=<nil> Rtype=TXT Ttl=300 Operation=ADD }
INFO[0190] All records are already up to date
INFO[0250] All records are already up to date

Verified the records are successfully added to the OCI Zone
Successfully reached the endpoint in my browser...

Undeployed the sample Service

INFO[0314] Change zone: "ocid1.dns-zone.oc1..162fffffffffffffffffffffffffffee1cabf"
INFO[0314] { Domain=nginx.jrosinsk.developer.redacted.com RecordHash=<nil> IsProtected=<nil> Rdata=x.x.x.x RrsetVersion=<nil> Rtype=A Ttl=300 Operation=REMOVE }
INFO[0314] { Domain=nginx.jrosinsk.developer.redacted.com RecordHash=<nil> IsProtected=<nil> Rdata="heritage=external-dns,external-dns/owner=default,external-dns/resource=service/default/nginx" RrsetVersion=<nil> Rtype=TXT Ttl=300 Operation=REMOVE }
INFO[0314] { Domain=a-nginx.jrosinsk.developer.redacted.com RecordHash=<nil> IsProtected=<nil> Rdata="heritage=external-dns,external-dns/owner=default,external-dns/resource=service/default/nginx" RrsetVersion=<nil> Rtype=TXT Ttl=300 Operation=REMOVE }
INFO[0369] All records are already up to date

Verified the records are removed from the OCI Zone

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 19, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 19, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jrosinsk / name: Joe Rosinski (38a93f3)

@k8s-ci-robot
Copy link
Contributor

Welcome @jrosinsk!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 19, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 19, 2023
@jrosinsk jrosinsk changed the title OCI provider: bump oci-go-sdk from 24.3.0+incompatible to 65.35.0 OCI provider: bump oci-go-sdk from 24.3.0 to 65.35.0 Apr 19, 2023
@jrosinsk jrosinsk marked this pull request as ready for review April 19, 2023 20:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 19, 2023
@k8s-ci-robot k8s-ci-robot requested a review from seanmalloy April 19, 2023 20:16
@jrosinsk jrosinsk force-pushed the jrosinsk/update-oci-go-sdk branch from 38a93f3 to 59ebd2b Compare April 20, 2023 19:26
jlamillan
jlamillan approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@jlamillan jlamillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ericrrath
Copy link
Contributor

ericrrath commented Apr 20, 2023 •
edited
Loading

lgtm

@szuecs
Copy link
Contributor

szuecs commented Apr 20, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlamillan, jrosinsk, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3923baf into kubernetes-sigs:master Apr 20, 2023
@jrosinsk jrosinsk deleted the jrosinsk/update-oci-go-sdk branch April 20, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlamillan jlamillan jlamillan approved these changes

@njuettner njuettner Awaiting requested review from njuettner

@szuecs szuecs Awaiting requested review from szuecs

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@szuecs szuecs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrosinsk @k8s-ci-robot @ericrrath @szuecs @jlamillan